feat(tests): add reentrancy suicide revert test#372
Conversation
marioevz
left a comment
There was a problem hiding this comment.
Looks great to me :) Just a few comments, which might need a rebase.
It might be worth it to run tox to highlight any other issues related to linting if any (Just run tox in the execution-spec-tests folder with venv enabled).
tests/cancun/eip6780_selfdestruct/test_double_selfdestruct_revert.py
Outdated
Show resolved
Hide resolved
tests/cancun/eip6780_selfdestruct/test_double_selfdestruct_revert.py
Outdated
Show resolved
Hide resolved
tests/cancun/eip6780_selfdestruct/test_double_selfdestruct_revert.py
Outdated
Show resolved
Hide resolved
19ae098 to
14ad8e5
Compare
|
LGTM! I'm nit-picking but it would be good to follow these 2 additional items that we started a few months ago. They don't need to be perfect but should help us in the future for finding issues or PRs in the future.
|
|
Can this also be scripted in github CI checks? |
|
Great idea, for the labels most likely and similarly with the Changelog! Maybe after a PR is created, depending on the labels assigned by the CI, the relavent PR name is given. Can discuss on this weeks call :) |
|
git commit also should have |
|
Also CI should try to fill the test and see if it actually fills without errors |
I'd say the ideal scenario is to have a single squashed commit message with the above yeah - purely for improved commit history on main :)
Tox should already be doing this, in the order specified within the tox.ini file |
🗒️ Description
Test requested by chfast about suicide reentrancy and revert.
🔗 Related Issues
Resolves this issue.
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.